added support for non-ascii directories and file names#860
Merged
3 commits merged intogitpython-developers:masterfrom Jul 20, 2019
Merged
added support for non-ascii directories and file names#8603 commits merged intogitpython-developers:masterfrom
3 commits merged intogitpython-developers:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
==========================================
- Coverage 94.79% 93.54% -1.25%
==========================================
Files 59 59
Lines 9603 9607 +4
==========================================
- Hits 9103 8987 -116
- Misses 500 620 +120
Continue to review full report at Codecov.
|
Member
|
Thanks a lot, and I would love to merge this. However, it appears the PR breaks a single test in Py 2.7, and I am not entirely sure these are related. So I am merging to test it in master, and revert as needed. |
Member
|
Unfortunately the build still fails on top of master for the same reason as before. I have no idea why this is happening. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix allows support for non-ascii filenames, both in workdir and repos. For instance, when your workdir contains non-ascii (0-255) characters,
git.Repo.clone_from()didn't work.Implementation:
It turned out that the amount of necessary changes is not big. The main problem was in that git.compat.defenc was set to sys.getdefaultencoding() instead of sys.getfilesystemencoding().
sys.getfilesystemencoding()requires Python 2.3. Thefrom builtins import strfixes several str(epath) etc. conversions that were causing UnicodeEncodeError. I have no idea what python2 version is necessary for that.I have tested the fix on Windows7 Pro x64, both with Python 2.7.13 and 3.7.3.