feat(core): Add span serialization utilities (spanToV2JSON) #19140
+378
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds utilities for serializing spans to the new V2 format: - `spanToV2JSON`: Converts a span to SerializedSpan (V2 format) - `getV2SpanLinks`: Converts span links with serialized attributes - `getV2StatusMessage`: Converts status to 'ok' | 'error' - `INTERNAL_getSegmentSpan`: Renamed from getRootSpan (with alias kept) These utilities are needed for the span streaming feature and will be used by subsequent PRs to serialize spans before sending. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Missing integration or E2E test for feature PR
Low Severity
Per the review rules file, feat PRs should include at least one integration or E2E test. This PR only includes unit tests for the new spanToStreamedSpanJSON and spanJsonToSerializedSpan utilities. While the PR discussion mentions this is part of building blocks for a larger feature, consider adding integration tests to verify the serialization pipeline works end-to-end when the feature is complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds span JSON conversion and serialization helpers for span streaming:
spanToStreamedSpanJSON: Converts aSpaninstance to a JSON object used as intermediate representation as outlined in feat(core/spans): Add span v2 and envelope type definitions #19100SentrySpan::getStreamedSpanJSONmethod to convert our own spansspanToJSONworks today.spanJsonToSerializedSpan: Converts aStreamedSpanJSONinto the finalSerializedSpanto be sent to Sentry.This PR also adds unit tests for both helpers.
ref #17836