加载中...
Skip to content

Conversation

@akchinSTC
Copy link
Member

Partially addresses #747

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Michonster and others added 10 commits July 22, 2022 15:13
test commit
Co-authored-by: Aarnav Patel <shadowluigi27@users.noreply.github.com>
adding new test to test_handlers to test pipeline json file
Updated test_handlers.py file
changed the body of the test
updated the test and changed the values to try and make it work.
Updated test_handlers.py to assert the contents of the dict
Updated pipeline tests so that they validate
Changed names of tests to better reflect what they do
@elyra-bot
Copy link

elyra-bot bot commented Aug 10, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _async_return functionality is cool! Other than that, yeah I think these tests pretty much cover what we want them to. My only NIT is that the comments could probably be cleaned up/edited a bit (though I know why they are as they are right now 🙂 )

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit ae59094 into elyra-ai:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:test Test-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants