-
Notifications
You must be signed in to change notification settings - Fork 366
Add export and validation handler tests #2876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test commit
Co-authored-by: Aarnav Patel <shadowluigi27@users.noreply.github.com>
adding new test to test_handlers to test pipeline json file
Updated test_handlers.py file
changed the body of the test
updated the test and changed the values to try and make it work.
Updated test_handlers.py to assert the contents of the dict
Updated pipeline tests so that they validate
Changed names of tests to better reflect what they do
|
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
kiersten-stokes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _async_return functionality is cool! Other than that, yeah I think these tests pretty much cover what we want them to. My only NIT is that the comments could probably be cleaned up/edited a bit (though I know why they are as they are right now 🙂 )
kiersten-stokes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Partially addresses #747
What changes were proposed in this pull request?
How was this pull request tested?
Developer's Certificate of Origin 1.1