加载中...
Skip to content

Conversation

@kevin-bates
Copy link
Member

A new version of sphinx-markdown-tables (0.0.16) was recently released and is compatible with the current Markdown release (3.4.1) that had previously broken sphinx-markdown-tables. This PR updates the relative minimum versions of these packages and removes the previously imposed cap and exclusion.

Fixes: #2837

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@kevin-bates kevin-bates added area:documentation Improvements or additions to documentation kind:CI Impacts continuous integration (build, test, etc.) labels Jul 25, 2022
@elyra-bot
Copy link

elyra-bot bot commented Jul 25, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added this to the 3.11.0 milestone Jul 25, 2022
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Doc build working and tables are rendering as expected

Screen Shot 2022-07-25 at 3 31 45 PM

@ptitzler
Copy link
Member

sphinx-markdown-tables 0.0.16 causes doc builds with Markdown < 3.4 to fail:

Extension error (sphinx_markdown_tables):
Handler <function process_tables at 0x7faf1779b3b0> for event 'source-read' threw an exception (exception: __init__() takes 2 positional arguments but 3 were given)

We therefore might have to cap sphinx-markdown-tables if we publish another 3.x.y patch release (x < 11).

@kevin-bates
Copy link
Member Author

Yes, that is correct. Good point. Damned if you, damned if you don't. 😁

@akchinSTC akchinSTC merged commit c567bf9 into elyra-ai:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:documentation Improvements or additions to documentation kind:CI Impacts continuous integration (build, test, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown versions 3.4.0 and 3.4.1 break documentation build

4 participants