feat(): unicode extended char support for column name or alias#58
Merged
albin3 merged 2 commits intoJavaScriptor:masterfrom Nov 5, 2023
Merged
feat(): unicode extended char support for column name or alias#58albin3 merged 2 commits intoJavaScriptor:masterfrom
albin3 merged 2 commits intoJavaScriptor:masterfrom
Conversation
31faa6a to
c4b243e
Compare
Contributor
Author
|
Sorry for the force, there was code that wasn't supposed to be committed |
Member
|
hi, @luizzappa thanks for the pr, it is a serious problem. Could you update this pr like this:
|
3ff5bc5 to
1064642
Compare
Contributor
Author
|
@albin3, Done. In my first commit I had indented the other lines to maintain the formatting, with this smaller pattern suggested by you I didn't need to do that, thanks. |
Member
|
hi @luizzappa , lGTM. |
Member
|
released at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, you cannot name (or alias) a column with certain Latin characters without using quotes, even though this is supported by MySQL syntax. In this PR, I added this.
Parser error:

MySQL syntax: